2 Replies Last post: Jun 4, 2008 1:56 AM by Guest  
Guest

Jun 4, 2008 1:08 AM

[OpenSIPStack] Contribute changes to OpenSIPStack?

Hello,

I did some changes to OpenSIPStack. Now my question is if it is possible
to contribute patches?

OpalOSSEndPoint.h.patch: replaced private with protected in
OpalOSSUserAgent to use derived SessionManager.

RegisterSessionManager.cxx.patch: moved creation of "registry" folder to
AddRegistrationRecovery(..) so it is only created if really needed.

Regards,
Matthias
Index: RegisterSessionManager.cxx
===================================================================
RCS file: /cvsroot/opensipstack/opensipstack/src/RegisterSessionManager.cxx,v
retrieving revision 1.45
diff -u -r1.45 RegisterSessionManager.cxx
      • RegisterSessionManager.cxx 8 Apr 2008 13:12:14 -0000 1.45
+ RegisterSessionManager.cxx 26 May 2008 14:41:39 -0000
@@ -507,8 +507,6 @@
#else
m_HasContactRecovery = TRUE;
OString dir = PProcess::Current().GetFile().GetDirectory() + "registry";
  • if( !PFile::Exists( dir.c_str() ) )
  • PDirectory::Create( dir.c_str() );
m_RegRecoveryDIR = dir.c_str();
#endif
}
@@ -739,6 +737,8 @@
{
PWaitAndSignal lock( m_RegRecoveryMutex );

+ if( !PFile::Exists( m_RegRecoveryDIR.c_str() ) )
+ PDirectory::Create( m_RegRecoveryDIR.c_str() );

OStringStream fn;
fn << m_RegRecoveryDIR << "/" << userURI.GetUser() << "at" << userURI.GetHost() << "_" << userURI.GetPort() << ".log";

Index: OpalOSSEndPoint.h
===================================================================
RCS file: /cvsroot/opensipstack/opensipstack/include/OpalOSSEndPoint.h,v
retrieving revision 1.39
diff -u -r1.39 OpalOSSEndPoint.h
      • OpalOSSEndPoint.h 13 May 2008 08:29:27 -0000 1.39
+ OpalOSSEndPoint.h 21 May 2008 05:58:26 -0000
@@ -461,7 +461,7 @@
PINLINE OpalOSSEndPoint & GetOpalEndPoint(){ return m_OpalEndPoint; };
PINLINE OpalOSSCore * GetCore(){return m_Core; };
PINLINE OpalOSSRegistrar * GetRegistrar(){ return m_Registrar; };
  • private:
+ protected:

OpalOSSEndPoint & m_OpalEndPoint;
OpalOSSCore * m_Core;


Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
opensipstack-devel mailing list
opensipstack-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
Guest
1. Jun 4, 2008 1:25 AM in response to: Guest
Re: [OpenSIPStack] Contribute changes to OpenSIPStack?
Hi Matthias,

I'll take a look. If they dont break anything, I'll commit it in CVS.
I'll let you know.

Joegen

Matthias Dreißig wrote:
Hello,

I did some changes to OpenSIPStack. Now my question is if it is
possible to contribute patches?

OpalOSSEndPoint.h.patch: replaced private with protected in
OpalOSSUserAgent to use derived SessionManager.

RegisterSessionManager.cxx.patch: moved creation of "registry" folder
to AddRegistrationRecovery(..) so it is only created if really needed.

Regards,
Matthias


Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php


_______________________________________________
opensipstack-devel mailing list
opensipstack-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensipstack-devel


Internal Virus Database is out-of-date.
Checked by AVG.
Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM



Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
opensipstack-devel mailing list
opensipstack-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensipstack-devel
Guest
2. Jun 4, 2008 1:56 AM in response to: Guest
Re: [OpenSIPStack] Contribute changes to OpenSIPStack?
Hi Matthias,

Modified your patches a bit so that PFile::Exists(
m_RegRecoveryDIR.c_str() ) will only be performed once within
AddRegistrationRecovery(). Your patches are in.

Thanks.

Joegen

joegen@opensipstack.org wrote:
Hi Matthias,

I'll take a look. If they dont break anything, I'll commit it in CVS.
I'll let you know.

Joegen

Matthias Dreißig wrote:

Hello,

I did some changes to OpenSIPStack. Now my question is if it is
possible to contribute patches?

OpalOSSEndPoint.h.patch: replaced private with protected in
OpalOSSUserAgent to use derived SessionManager.

RegisterSessionManager.cxx.patch: moved creation of "registry" folder
to AddRegistrationRecovery(..) so it is only created if really needed.

Regards,
Matthias


Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php


_______________________________________________
opensipstack-devel mailing list
opensipstack-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensipstack-devel


Internal Virus Database is out-of-date.
Checked by AVG.
Version: 7.5.524 / Virus Database: 269.24.1/1463 - Release Date: 5/23/2008 3:36 PM

Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
opensipstack-devel mailing list
opensipstack-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensipstack-devel



Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
opensipstack-devel mailing list
opensipstack-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensipstack-devel